From: Laine Stump Date: Thu, 3 May 2012 15:52:17 +0000 (-0400) Subject: util: remove error log from stubs of virNetlinkEventServiceStart|Stop X-Git-Tag: v0.9.12-rc2~26 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bae4ff282bb95c4a0b035a0e3c00964f88e81d25;p=thirdparty%2Flibvirt.git util: remove error log from stubs of virNetlinkEventServiceStart|Stop These two functions are called from main() on all platforms, and always return success on platforms that don't support libnl. They still log an error message, though, which doesn't make sense - they should just be NOPs on those platforms. (Per a suggestion during review, I've turned the logs into debug messages rather than removing them completely). --- diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index e609494ffc..25a39f193a 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -561,7 +561,7 @@ int virNetlinkCommand(struct nl_msg *nl_msg ATTRIBUTE_UNUSED, */ int virNetlinkEventServiceStop(void) { - netlinkError(VIR_ERR_INTERNAL_ERROR, "%s", _(unsupported)); + VIR_DEBUG("%s", _(unsupported)); return 0; } @@ -571,7 +571,7 @@ int virNetlinkEventServiceStop(void) */ int virNetlinkEventServiceStart(void) { - netlinkError(VIR_ERR_INTERNAL_ERROR, "%s", _(unsupported)); + VIR_DEBUG("%s", _(unsupported)); return 0; }