From: Andrew Bartlett <abartlet@samba.org>
Date: Mon, 23 Apr 2012 03:47:46 +0000 (+1000)
Subject: s4-libnet: Fix segfault shown by wbinfo --group-info=administrator
X-Git-Tag: samba-4.0.0alpha20~142
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bb3d983f5bc4b49619f26af44c3c540c3030155f;p=thirdparty%2Fsamba.git

s4-libnet: Fix segfault shown by wbinfo --group-info=administrator

The issue was that after the LookupNames call indicated that this was
not a group, the call paths diverged, with both sucess and failure
paths running.

Andrew Bartlett
---

diff --git a/source4/libnet/libnet_group.c b/source4/libnet/libnet_group.c
index 5d8f9e200a8..b12037e1f38 100644
--- a/source4/libnet/libnet_group.c
+++ b/source4/libnet/libnet_group.c
@@ -337,6 +337,7 @@ static void continue_name_found(struct composite_context *ctx)
 	if (s->lookup.out.sid_type != SID_NAME_DOM_GRP &&
 	    s->lookup.out.sid_type != SID_NAME_ALIAS) {
 		composite_error(c, NT_STATUS_NO_SUCH_GROUP);
+		return;
 	}
 
 	/* prepare arguments for groupinfo call */