From: Eric Blake <eblake@redhat.com>
Date: Thu, 2 Jun 2011 21:50:11 +0000 (-0600)
Subject: command: avoid leak on failure
X-Git-Tag: v0.9.2~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bb8895290cff13048d03753119cbeb207f668ed9;p=thirdparty%2Flibvirt.git

command: avoid leak on failure

Detected by Coverity.  While it is possible on OOM condition, as
well as with bad code that passes binary == NULL, it is unlikely
to be encountered in the wild.

* src/util/command.c (virCommandNewArgList): Don't leak memory.
---

diff --git a/src/util/command.c b/src/util/command.c
index 288958eb3f..a2f7ff6223 100644
--- a/src/util/command.c
+++ b/src/util/command.c
@@ -142,7 +142,7 @@ virCommandNewArgList(const char *binary, ...)
     const char *arg;
 
     if (!cmd || cmd->has_error)
-        return NULL;
+        return cmd;
 
     va_start(list, binary);
     while ((arg = va_arg(list, const char *)) != NULL)