From: Muraoka Taro Date: Wed, 17 Dec 2025 19:52:32 +0000 (+0100) Subject: patch 9.1.1990: tests: Test_term_gettty() fails when using conpty on Windows X-Git-Tag: v9.1.1990^0 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bbbc23ac2f6767630ebd7da9754ee0501a585c1a;p=thirdparty%2Fvim.git patch 9.1.1990: tests: Test_term_gettty() fails when using conpty on Windows Problem: tests: Test_term_gettty() fails when using conpty on Windows, CI uses winpty, so this test passes. Solution: Skip the test Test_term_gettty(). Since conpty communicates via anonymous pipes, there is no name that can be obtained with term_gettty() (Muraoka Taro) closes: #18954 Signed-off-by: Muraoka Taro Signed-off-by: Christian Brabandt --- diff --git a/src/testdir/test_vim9_builtin.vim b/src/testdir/test_vim9_builtin.vim index e66a33b6e9..a07ba8c099 100644 --- a/src/testdir/test_vim9_builtin.vim +++ b/src/testdir/test_vim9_builtin.vim @@ -4766,6 +4766,9 @@ def Test_term_gettty() CheckFeature terminal else var buf = g:Run_shell_in_terminal({}) + if has('win32') && buf->term_getjob()->job_info()['tty_type'] == 'conpty' + throw 'Skipped: When using conpty, term_gettty() always returns an empty string.' + endif term_gettty(buf, true)->assert_notequal('') g:StopShellInTerminal(buf) endif diff --git a/src/version.c b/src/version.c index 1b406f8922..a368907018 100644 --- a/src/version.c +++ b/src/version.c @@ -734,6 +734,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 1990, /**/ 1989, /**/