From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Sat, 1 Jun 2024 14:00:30 +0000 (+0200)
Subject: maint: improve ERE in sc_tests_list_consistency
X-Git-Tag: v9.6~221
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bbc972bc827aa5b34fce697ed79a36c70c4fabe3;p=thirdparty%2Fcoreutils.git

maint: improve ERE in sc_tests_list_consistency

The ERE used lacks the grouping of the extensions and therefore would
also match files where the first two patterns are not at the end of
the line:
  grep -E '\.sh|\.pl|\.xpl$'

* cfg.mk (sc_tests_list_consistency): Add grouping (...) around the
sub-patterns.  While at it, also remove the redundant escaping, i.e.,
\$$ -> $$ to be consistent with the rest of this file.
---

diff --git a/cfg.mk b/cfg.mk
index 2cfb31877f..647b6600ed 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -121,7 +121,7 @@ sc_tests_list_consistency:
 	  cd $(top_srcdir);						\
 	  $(SHELL) build-aux/vc-list-files tests			\
 	    | grep -Ev '^tests/(factor/(run|create-test)|init)\.sh$$'	\
-	    | grep -E "$$test_extensions_rx\$$";			\
+	    | grep -E "($$test_extensions_rx)$$";			\
 	} | sort | uniq -u | grep . && exit 1; :
 
 # Ensure that all version-controlled test scripts are executable.