From: Willy Tarreau <w@1wt.eu>
Date: Mon, 23 Feb 2026 14:42:04 +0000 (+0100)
Subject: CLENAUP: cfgparse: accept-invalid-http-* does not support "no"/"defaults"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bbd8492c2220f1b4a11ee0d7319da9578f2c0845;p=thirdparty%2Fhaproxy.git

CLENAUP: cfgparse: accept-invalid-http-* does not support "no"/"defaults"

Some options do not support "no" nor "defaults" and they're placed after
the check for their absence. However, "accept-invalid-http-request" and
"accept-invalid-http-response" still used to check for the flags that
come with these prefixes, but Coverity noticed this was dead code in
github issue #3272. Let's just drop the test.

No backport needed as it's just dead code.
---

diff --git a/src/cfgparse-listen.c b/src/cfgparse-listen.c
index 3bce9dd0b..12d42782e 100644
--- a/src/cfgparse-listen.c
+++ b/src/cfgparse-listen.c
@@ -2454,18 +2454,7 @@ stats_error_parsing:
 			}
 
 			curproxy->no_options2 &= ~val;
-			curproxy->options2    &= ~val;
-
-			switch (kwm) {
-			case KWM_STD:
-				curproxy->options2 |= val;
-				break;
-			case KWM_NO:
-				curproxy->no_options2 |= val;
-				break;
-			case KWM_DEF: /* already cleared */
-				break;
-			}
+			curproxy->options2    |= val;
 
 			err_code |= ERR_WARN;
 			goto out;