From: Luke Howard <lukeh@padl.com>
Date: Wed, 16 Sep 2009 18:01:12 +0000 (+0000)
Subject: 1. s4u_creds.c:build_pa_for_user frees uninitialized for_user.cksum if
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bbe4c21f3956e5ba41cf079e640882fea299bc06;p=thirdparty%2Fkrb5.git

1. s4u_creds.c:build_pa_for_user frees uninitialized for_user.cksum if
the cleanup handler is taken before a successful
make_pa_for_user_checksum.

git-svn-id: svn://anonsvn.mit.edu/krb5/users/lhoward/authdata@22773 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/krb5/krb/s4u_creds.c b/src/lib/krb5/krb/s4u_creds.c
index 1f294c427c..eec35a6672 100644
--- a/src/lib/krb5/krb/s4u_creds.c
+++ b/src/lib/krb5/krb/s4u_creds.c
@@ -207,12 +207,13 @@ build_pa_for_user(krb5_context context,
     krb5_data *for_user_data = NULL;
     char package[] = "Kerberos";
 
+    memset(&for_user, 0, sizeof(for_user));
+
     if (userid->user == NULL) {
         code = EINVAL;
         goto cleanup;
     }
 
-    memset(&for_user, 0, sizeof(for_user));
     for_user.user = userid->user;
     for_user.auth_package.data = package;
     for_user.auth_package.length = sizeof(package) - 1;