From: Volker Lendecke <vl@samba.org>
Date: Wed, 8 Oct 2014 13:39:28 +0000 (+0200)
Subject: registry: Don't leave dangling transactions
X-Git-Tag: samba-4.0.23~50
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bbf24d39b4c0ba81767bcdb67d5cd7c01604b16c;p=thirdparty%2Fsamba.git

registry: Don't leave dangling transactions

When a createkey fails due to access denied, we need to do a
transaction_cancel. Otherwise the lock on the db will stay around.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10860
---

diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index c263174bc23..1d4746a8462 100644
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -628,7 +628,7 @@ WERROR reg_createkey(TALLOC_CTX *ctx, struct registry_key *parent,
 				 key->token))
 	{
 		err = WERR_ACCESS_DENIED;
-		goto done;
+		goto trans_done;
 	}
 
 	/*