From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 24 May 2017 15:57:29 +0000 (-0400)
Subject: better notes on stream transport issues
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bbf36e3005864ccb5a366115f5887597780b47b8;p=thirdparty%2Ffreeradius-server.git

better notes on stream transport issues
---

diff --git a/src/lib/io/network.c b/src/lib/io/network.c
index 73ef04a3852..a0be022b9e7 100644
--- a/src/lib/io/network.c
+++ b/src/lib/io/network.c
@@ -362,16 +362,9 @@ static void fr_network_read(UNUSED fr_event_list_t *el, int sockfd, void *ctx)
 		 *	need to be able to give the same buffer back
 		 *	to the stream socket for subsequent reads.
 		 *
-		 *	The only worry with this approach is that slow
-		 *	stream sockets MAY do "head of line" blocking
-		 *	on the ring buffers.
-		 *
-		 *	i.e. if the transport read returns 0, we MAY
-		 *	want to copy the data somewhere else.  OR, we
-		 *	may want to relax our promises to the
-		 *	transport, and demand that the transport not
-		 *	write to the message buffer until it has an
-		 *	entire packet.
+		 *	Since we have a message set for each
+		 *	fr_transport_socket_t, no "head of line"
+		 *	blocking issues can happen for stream sockets.
 		 */
 		s->cd = cd;
 		return;