From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 9 Sep 2014 15:09:58 +0000 (+0200)
Subject: util: process: Don't report OOM errors in helper
X-Git-Tag: CVE-2014-3633~116
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bc068034babd222099c74612e7ab6c91e9a565fe;p=thirdparty%2Flibvirt.git

util: process: Don't report OOM errors in helper

virProcessTranslateStatus is used on error paths that should not spoil
the returned error. As the errors are ignored, use the quiet versions of
virAsprintf to create the message.
---

diff --git a/src/util/virprocess.c b/src/util/virprocess.c
index 97cce4fc5f..5bb2298241 100644
--- a/src/util/virprocess.c
+++ b/src/util/virprocess.c
@@ -73,13 +73,13 @@ virProcessTranslateStatus(int status)
 {
     char *buf;
     if (WIFEXITED(status)) {
-        ignore_value(virAsprintf(&buf, _("exit status %d"),
-                                 WEXITSTATUS(status)));
+        ignore_value(virAsprintfQuiet(&buf, _("exit status %d"),
+                                      WEXITSTATUS(status)));
     } else if (WIFSIGNALED(status)) {
-        ignore_value(virAsprintf(&buf, _("fatal signal %d"),
-                                 WTERMSIG(status)));
+        ignore_value(virAsprintfQuiet(&buf, _("fatal signal %d"),
+                                      WTERMSIG(status)));
     } else {
-        ignore_value(virAsprintf(&buf, _("invalid value %d"), status));
+        ignore_value(virAsprintfQuiet(&buf, _("invalid value %d"), status));
     }
     return buf;
 }