From: Long Li Date: Mon, 25 Nov 2024 21:14:11 +0000 (-0800) Subject: xfs: remove the redundant xfs_alloc_log_agf X-Git-Tag: v6.13.0~212 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bc494cfd76a42b3b42b2f20d53e701254d6ef1b1;p=thirdparty%2Fxfsprogs-dev.git xfs: remove the redundant xfs_alloc_log_agf Source kernel commit: 8b9b261594d8ef218ef4d0e732dad153f82aab49 There are two invocations of xfs_alloc_log_agf in xfs_alloc_put_freelist. The AGF does not change between the two calls. Although this does not pose any practical problems, it seems like a small mistake. Therefore, fix it by removing the first xfs_alloc_log_agf invocation. Signed-off-by: Long Li Reviewed-by: Dave Chinner Signed-off-by: Carlos Maiolino Reviewed-by: Christoph Hellwig --- diff --git a/libxfs/xfs_alloc.c b/libxfs/xfs_alloc.c index f0635b17..355f8ef1 100644 --- a/libxfs/xfs_alloc.c +++ b/libxfs/xfs_alloc.c @@ -3152,8 +3152,6 @@ xfs_alloc_put_freelist( logflags |= XFS_AGF_BTREEBLKS; } - xfs_alloc_log_agf(tp, agbp, logflags); - ASSERT(be32_to_cpu(agf->agf_flcount) <= xfs_agfl_size(mp)); agfl_bno = xfs_buf_to_agfl_bno(agflbp);