From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 15 Mar 2022 11:37:44 +0000 (+0100)
Subject: qemu_cgroup: Drop ENOENT special case for RNG devices
X-Git-Tag: v8.2.0-rc1~84
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bc51dac71389c6ba17471a7c5131debd1a3b4d88;p=thirdparty%2Flibvirt.git

qemu_cgroup: Drop ENOENT special case for RNG devices

When allowing or denying RNG device in CGroups there's a special
check if the backend device exists (errno == ENOENT) in which
case success is returned to caller. This is in contrast with the
rest of the functions and in fact wrong too - if the backend
device doesn't exist then QEMU will fail opening it. Might as
well signal error here.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
---

diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 34b50ddd1d..9d47803fce 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -630,8 +630,7 @@ qemuSetupRNGCgroup(virDomainObj *vm,
         virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
                                  rng->source.file,
                                  "rw", rv);
-        if (rv < 0 &&
-            !virLastErrorIsSystemErrno(ENOENT))
+        if (rv < 0)
             return -1;
     }
 
@@ -657,8 +656,7 @@ qemuTeardownRNGCgroup(virDomainObj *vm,
         virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
                                  rng->source.file,
                                  "rw", rv);
-        if (rv < 0 &&
-            !virLastErrorIsSystemErrno(ENOENT))
+        if (rv < 0)
             return -1;
     }