From: Volker Lendecke <vl@samba.org>
Date: Tue, 29 Sep 2020 08:17:29 +0000 (+0200)
Subject: smbd: Use GUID_to_ndr_buf() in smbXsrv_client_global_id_to_key()
X-Git-Tag: talloc-2.3.2~309
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bc6388712458ae4a278ac98b0a2f2bb286840923;p=thirdparty%2Fsamba.git

smbd: Use GUID_to_ndr_buf() in smbXsrv_client_global_id_to_key()

Avoid a talloc/free

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/smbXsrv_client.c b/source3/smbd/smbXsrv_client.c
index fcfa225048a..93e2509041d 100644
--- a/source3/smbd/smbXsrv_client.c
+++ b/source3/smbd/smbXsrv_client.c
@@ -105,14 +105,13 @@ static TDB_DATA smbXsrv_client_global_id_to_key(const struct GUID *client_guid,
 {
 	TDB_DATA key = { .dsize = 0, };
 	NTSTATUS status;
-	DATA_BLOB b;
+	struct GUID_ndr_buf buf = { .buf = {0}, };
 
-	status = GUID_to_ndr_blob(client_guid, talloc_tos(), &b);
+	status = GUID_to_ndr_buf(client_guid, &buf);
 	if (!NT_STATUS_IS_OK(status)) {
 		return key;
 	}
-	memcpy(key_buf, b.data, SMBXSRV_CLIENT_GLOBAL_TDB_KEY_SIZE);
-	data_blob_free(&b);
+	memcpy(key_buf, buf.buf, SMBXSRV_CLIENT_GLOBAL_TDB_KEY_SIZE);
 
 	key = make_tdb_data(key_buf, SMBXSRV_CLIENT_GLOBAL_TDB_KEY_SIZE);