From: Matthijs Mekking Date: Mon, 4 Jun 2012 13:39:11 +0000 (+0000) Subject: if we print (null) in an RR, we should return an error status X-Git-Tag: release-1.6.14rc1~62 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bc90a1698a69299232773c8679490167fd6c80ba;p=thirdparty%2Fldns.git if we print (null) in an RR, we should return an error status (maybe even set buffer status to error?) --- diff --git a/host2str.c b/host2str.c index 2ec8ae19..858b1c11 100644 --- a/host2str.c +++ b/host2str.c @@ -1152,7 +1152,7 @@ ldns_rdf2buffer_str(ldns_buffer *buffer, const ldns_rdf *rdf) } else { /** This will write mangled RRs */ ldns_buffer_printf(buffer, "(null) "); - res = ldns_buffer_status(buffer); + res = LDNS_STATUS_ERR; } return res; } diff --git a/rr.c b/rr.c index 8f4ce85c..e11594f5 100644 --- a/rr.c +++ b/rr.c @@ -119,7 +119,7 @@ ldns_rr_new_frm_str_internal(ldns_rr **newrr, const char *str, char *type = NULL; char *rdata = NULL; char *rd = NULL; - char *b64 = NULL; + char * b64 = NULL; size_t rd_strlen; const char *delimiters; ssize_t c;