From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sun, 21 Jul 2024 10:34:06 +0000 (+0200)
Subject: config: stop passing static value
X-Git-Tag: v24~7^2~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bcb0336ca4233ad7f9bdff3045dfced9a054c5de;p=thirdparty%2Fmkosi.git

config: stop passing static value

ConfigAction used to be a dynamically generated class, but fortunately
it's not anymore, so we can simplify this.
---

diff --git a/mkosi/config.py b/mkosi/config.py
index e4e280eac..c7bf5795d 100644
--- a/mkosi/config.py
+++ b/mkosi/config.py
@@ -3172,7 +3172,7 @@ SPECIFIERS_LOOKUP_BY_CHAR = {s.char: s for s in SPECIFIERS}
 FALLBACK_NAME_TO_DEST_SPLITTER = re.compile("(?<=[a-z])(?=[A-Z])")
 
 
-def create_argument_parser(action: type[argparse.Action], chdir: bool = True) -> argparse.ArgumentParser:
+def create_argument_parser(chdir: bool = True) -> argparse.ArgumentParser:
     parser = argparse.ArgumentParser(
         prog="mkosi",
         description="Build Bespoke OS Images",
@@ -3327,7 +3327,7 @@ def create_argument_parser(action: type[argparse.Action], chdir: bool = True) ->
             nargs=s.nargs,     # type: ignore
             const=s.const,
             help=s.help,
-            action=action,
+            action=ConfigAction,
         )
 
     return parser
@@ -3736,7 +3736,7 @@ def parse_config(argv: Sequence[str] = (), *, resources: Path = Path("/")) -> tu
     setattr(context.config, "image", None)
 
     # First, we parse the command line arguments into a separate namespace.
-    argparser = create_argument_parser(ConfigAction)
+    argparser = create_argument_parser()
     with context.parse_new_includes():
         argparser.parse_args(argv, context.cli)
     args = load_args(context.cli)