From: Martin Mares <mj@ucw.cz>
Date: Tue, 20 Jun 2000 07:49:08 +0000 (+0000)
Subject: Don't accept incoming connections when the neighbor is not up.
X-Git-Tag: v1.2.0~515
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bcbdcbb6ae7256e01165220bb3b2d5b72850f665;p=thirdparty%2Fbird.git

Don't accept incoming connections when the neighbor is not up.
---

diff --git a/proto/bgp/bgp.c b/proto/bgp/bgp.c
index 6bdb5fc01..72eba1af3 100644
--- a/proto/bgp/bgp.c
+++ b/proto/bgp/bgp.c
@@ -383,7 +383,7 @@ bgp_incoming_connection(sock *sk, int dummy)
 	if (ipa_equal(p->cf->remote_ip, sk->daddr))
 	  {
 	    match = 1;
-	    if (p->p.proto_state == PS_START || p->p.proto_state == PS_UP)
+	    if ((p->p.proto_state == PS_START || p->p.proto_state == PS_UP) && p->neigh && p->neigh->iface)
 	      {
 		BGP_TRACE(D_EVENTS, "Incoming connection from %I port %d", sk->daddr, sk->dport);
 		if (p->incoming_conn.sk)
@@ -488,6 +488,7 @@ bgp_start(struct proto *P)
   p->outgoing_conn.state = BS_IDLE;
   p->incoming_conn.state = BS_IDLE;
   p->startup_delay = 0;
+  p->neigh = NULL;
 
   bgp_counter++;
   bgp_setup_listen_sk();