From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Tue, 16 Feb 2010 00:12:02 +0000 (-0800)
Subject: * Disable the Voting extension by default.
X-Git-Tag: bugzilla-3.7.1~254
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bcd2c583433d27295bff332398935252ddcc5b7a;p=thirdparty%2Fbugzilla.git

* Disable the Voting extension by default.
* There was a syntax error in the code-error-errors.html.tmpl hook in the
  Voting extension.
* Creating the TestProduct during checksetup was throwing an warning
  about use of an uninitialized value, due to the Voting extension.

https://bugzilla.mozilla.org/show_bug.cgi?id=372979
---

diff --git a/extensions/Voting/Extension.pm b/extensions/Voting/Extension.pm
index 6857135eb6..47105bf987 100644
--- a/extensions/Voting/Extension.pm
+++ b/extensions/Voting/Extension.pm
@@ -326,7 +326,7 @@ sub _check_votestoconfirm {
 sub _check_votes {
     my ($default, $invocant, $votes, $field) = @_;
 
-    detaint_natural($votes);
+    detaint_natural($votes) if defined $votes;
     # On product creation, if the number of votes is not a valid integer,
     # we silently fall back to the given default value.
     # If the product already exists and the change is illegal, we complain.
diff --git a/extensions/Voting/disabled b/extensions/Voting/disabled
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl b/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl
index 719cbe4c11..50e9159416 100644
--- a/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl
+++ b/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl
@@ -22,3 +22,4 @@
     [% title = "$terms.Bug Cannot Be Confirmed" %]
     There is no valid transition from
     [%+ display_value("bug_status", "UNCONFIRMED") FILTER html %] to an open state
+[% END %]