From: Volker Lendecke <vl@samba.org>
Date: Mon, 28 Nov 2022 09:58:46 +0000 (+0100)
Subject: lib: Use talloc_asprintf_addbuf() in ldif_write_prefixMap()
X-Git-Tag: talloc-2.4.0~252
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bcdbe6ef6b59ae3638f263fbd5ddf4107c3f52cf;p=thirdparty%2Fsamba.git

lib: Use talloc_asprintf_addbuf() in ldif_write_prefixMap()

The first call of talloc_asprintf_append() did not have a NULL check.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/lib/ldb-samba/ldif_handlers.c b/lib/ldb-samba/ldif_handlers.c
index fa05168d36a..b8f04747456 100644
--- a/lib/ldb-samba/ldif_handlers.c
+++ b/lib/ldb-samba/ldif_handlers.c
@@ -713,7 +713,7 @@ static int ldif_write_prefixMap(struct ldb_context *ldb, void *mem_ctx,
 		char *partial_oid = NULL;
 
 		if (i > 0) {
-			string = talloc_asprintf_append(string, ";");
+			talloc_asprintf_addbuf(&string, ";");
 		}
 
 		oid_blob = data_blob_const(blob->ctr.dsdb.mappings[i].oid.binary_oid,
@@ -723,13 +723,10 @@ static int ldif_write_prefixMap(struct ldb_context *ldb, void *mem_ctx,
 				  blob->ctr.dsdb.mappings[i].id_prefix));
 			goto failed;
 		}
-		string = talloc_asprintf_append(string, "%u:%s",
-						   blob->ctr.dsdb.mappings[i].id_prefix,
-						   partial_oid);
+		talloc_asprintf_addbuf(&string, "%u:%s",
+				       blob->ctr.dsdb.mappings[i].id_prefix,
+				       partial_oid);
 		talloc_free(discard_const(partial_oid));
-		if (string == NULL) {
-			goto failed;
-		}
 	}
 
 	talloc_free(blob);