From: Alessio Podda <alessio@isc.org>
Date: Thu, 16 Apr 2026 09:56:46 +0000 (+0200)
Subject: Add missing parenthesis to fxhash
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bcfa2adaa311b9d2589f54c673d042d5fdf5a67d;p=thirdparty%2Fbind9.git

Add missing parenthesis to fxhash

The fxhash implementation had a missing parenthesis that caused it to
diverge from Rust's reference implementation. This commit fixes this.
---

diff --git a/lib/isc/include/isc/fxhash.h b/lib/isc/include/isc/fxhash.h
index 8cfbd323777..56273f55cba 100644
--- a/lib/isc/include/isc/fxhash.h
+++ b/lib/isc/include/isc/fxhash.h
@@ -40,7 +40,7 @@
 
 static inline size_t
 fx_add_to_hash(size_t hash, size_t i) {
-	return ISC_ROTATE_LEFT(hash, 5) ^ i * K;
+	return (ISC_ROTATE_LEFT(hash, 5) ^ i) * K;
 }
 
 /*