From: Christopher Faulet <cfaulet@haproxy.com>
Date: Wed, 10 Mar 2021 14:39:16 +0000 (+0100)
Subject: BUG/MINOR: resolvers: Consider server to have no IP on DNS resolution error
X-Git-Tag: v2.4-dev12~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bd0227c1096ecc9e11da315c399b178b16ad7a9d;p=thirdparty%2Fhaproxy.git

BUG/MINOR: resolvers: Consider server to have no IP on DNS resolution error

When an error is received for a DNS resolution, for instance a NXDOMAIN
error, the server must be considered to have no address when its status is
updated, not the opposite.

Concretly, because this parameter is not used on error path in
snr_update_srv_status(), there is no impact.

This patch must be backported as far as 1.8.
---

diff --git a/src/server.c b/src/server.c
index ed9925ecc3..18996a016f 100644
--- a/src/server.c
+++ b/src/server.c
@@ -3293,7 +3293,7 @@ int snr_resolution_error_cb(struct resolv_requester *requester, int error_code)
 	if (!s)
 		return 1;
 	HA_SPIN_LOCK(SERVER_LOCK, &s->lock);
-	snr_update_srv_status(s, 0);
+	snr_update_srv_status(s, 1);
 	memset(&s->addr, 0, sizeof(s->addr));
 	HA_SPIN_UNLOCK(SERVER_LOCK, &s->lock);
 	return 1;