From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 11 Aug 2021 14:46:31 +0000 (-0400)
Subject: Revert "close connection on "no TLS data, but connection isn't set up""
X-Git-Tag: release_3_0_24~62
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bd0cdab03ef3f38682cbd21e3829c7cc0b43dbb9;p=thirdparty%2Ffreeradius-server.git

Revert "close connection on "no TLS data, but connection isn't set up""

This reverts commit 75620b2fb9e7eb4f7853373fe3ffc2f67e97bb22.

not needed
---

diff --git a/src/main/tls_listen.c b/src/main/tls_listen.c
index e1d13ae3e8e..aaf7e4937ce 100644
--- a/src/main/tls_listen.c
+++ b/src/main/tls_listen.c
@@ -506,21 +506,9 @@ check_for_setup:
 	 *	presented by the client.
 	 */
 	if (sock->state == LISTEN_TLS_INIT) {
-		/*
-		 *	If INIT isn't finished, but there's no data,
-		 *	just close the connection.  The other end is
-		 *	being unfriendly.
-		 */
 		if (!SSL_is_init_finished(sock->ssn->ssl)) {
-			listener->status = RAD_LISTEN_STATUS_REMOVE_NOW;
-			listener->tls = NULL; /* parent owns this! */
-			PTHREAD_MUTEX_UNLOCK(&sock->mutex);
-
-			/*
-			 *	Tell the event handler that an FD has disappeared.
-			 */
-			radius_update_listener(listener);
-			return 0;
+			RDEBUG("FAILED in TLS handshake receive");
+			goto do_close;
 		}
 
 		sock->ssn->is_init_finished = true;