From: Andrei Borzenkov <arvidjaar@gmail.com>
Date: Mon, 26 Jan 2015 19:44:45 +0000 (+0300)
Subject: util/setup: fix memory leak.
X-Git-Tag: 2.02-beta3~471
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bd196014ec4eed6b4671cac4f4cb73621b219afa;p=thirdparty%2Fgrub.git

util/setup: fix memory leak.

Found by: Coverity scan.
---

diff --git a/util/setup.c b/util/setup.c
index ed4bd1113..b2991595b 100644
--- a/util/setup.c
+++ b/util/setup.c
@@ -670,15 +670,17 @@ unable_to_embed:
     if (dest_dev->disk->id != root_dev->disk->id
 	|| dest_dev->disk->dev->id != root_dev->disk->dev->id)
       {
-	const char *dest_ofpath;
+	char *dest_ofpath;
 	dest_ofpath
 	  = grub_util_devname_to_ofpath (grub_util_biosdisk_get_osdev (root_dev->disk));
+	/* FIXME handle NULL result */
 	grub_util_info ("dest_ofpath is `%s'", dest_ofpath);
 	strncpy (boot_devpath, dest_ofpath,
 		 GRUB_BOOT_MACHINE_BOOT_DEVPATH_END
 		 - GRUB_BOOT_MACHINE_BOOT_DEVPATH - 1);
 	boot_devpath[GRUB_BOOT_MACHINE_BOOT_DEVPATH_END
 		   - GRUB_BOOT_MACHINE_BOOT_DEVPATH - 1] = 0;
+	free (dest_ofpath);
       }
     else
       {