From: Miroslav Lichvar Date: Mon, 24 Jul 2017 11:24:17 +0000 (+0200) Subject: client: avoid undefined bit shifts X-Git-Tag: 3.2-pre1~8 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bd3fb49a1e45d66af3185407c30a75878ae7776a;p=thirdparty%2Fchrony.git client: avoid undefined bit shifts --- diff --git a/client.c b/client.c index 5e179df9..fa9e14e9 100644 --- a/client.c +++ b/client.c @@ -315,7 +315,7 @@ bits_to_mask(int bits, int family, IPAddr *mask) mask->family = family; switch (family) { case IPADDR_INET4: - if (bits < 0) + if (bits > 32 || bits < 0) bits = 32; if (bits > 0) { mask->addr.in4 = -1; @@ -2809,7 +2809,7 @@ process_cmd_retries(const char *line) int retries; retries = atoi(line); - if (retries < 0) { + if (retries < 0 || retries > 30) { LOG(LOGS_ERR, "Invalid maximum number of retries"); return 0; }