From: Andrew Bartlett <abartlet@samba.org>
Date: Thu, 11 Apr 2024 02:33:16 +0000 (+1200)
Subject: selftest: Remove duplicate setup of "spn/upn namespaces" in the customdc testenv
X-Git-Tag: tdb-1.4.11~1138
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bd60c605ca1cf3f3568646dc3c0ca3501f0bfbec;p=thirdparty%2Fsamba.git

selftest: Remove duplicate setup of "spn/upn namespaces" in the customdc testenv

The call to $self->setup_namespaces() was allways in error, as the design
is to have the in the state that it was backed up in, but before commit
08be28241b808845c4b51a4c47765a9416ca3aa7 the error return was not
checked and so this was harmless.

The customdc environment is not tested in selftest currently, as
it is intended to be used for manual testing of domains from backup
files not as an automatically constructed environment.

This makes:
 BACKUP_FILE=samba-backup-2024-04-11T14-10-20.437096.tar.bz2 SELFTEST_TESTENV=customdc make testenv
work again.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jo Sutton <josutton@catalyst.net.nz>
---

diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index f2b84b4f9b7..48a78b2c8d2 100755
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -3725,10 +3725,6 @@ sub setup_customdc
 	my $upn_array = ["$env->{REALM}.upn"];
 	my $spn_array = ["$env->{REALM}.spn"];
 
-	if ($self->setup_namespaces($env, $upn_array, $spn_array) != 0) {
-		return undef;
-	}
-
 	return $env;
 }