From: bert hubert <bert.hubert@powerdns.com>
Date: Mon, 6 Jun 2016 15:09:55 +0000 (+0200)
Subject: fix up leaking case statement, hopefully fix axfr of nsec3 zones again
X-Git-Tag: rec-4.0.0-rc1~4^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bd9602fa1b9e1e5fb3e6c0ca2abf8970bbc39819;p=thirdparty%2Fpdns.git

fix up leaking case statement, hopefully fix axfr of nsec3 zones again
---

diff --git a/pdns/slavecommunicator.cc b/pdns/slavecommunicator.cc
index d19383b471..e0a6fa75a4 100644
--- a/pdns/slavecommunicator.cc
+++ b/pdns/slavecommunicator.cc
@@ -189,7 +189,7 @@ static bool processRecordForZS(const DNSName& domain, bool& firstNSEC3, DNSResou
     zs.ns3pr = NSEC3PARAMRecordContent(rr.content);
     zs.isDnssecZone = zs.isNSEC3 = true;
     zs.isNarrow = false;
-  
+    break;
   case QType::NSEC3: {
     NSEC3RecordContent ns3rc(rr.content);
     if (firstNSEC3) {
@@ -202,16 +202,17 @@ static bool processRecordForZS(const DNSName& domain, bool& firstNSEC3, DNSResou
       DNSName hashPart = DNSName(toLower(rr.qname.makeRelative(domain).toString()));
       zs.secured.insert(hashPart);
     }
+    break;
   }
   
   case QType::NSEC: 
     zs.isDnssecZone = zs.isPresigned = true;
-  
+    break;
   
   case QType::NS: 
     if(rr.qname!=domain)
       zs.nsset.insert(rr.qname);
-  
+    break;
   }
 
   zs.qnames.insert(rr.qname);
@@ -345,7 +346,7 @@ void CommunicatorClass::suck(const DNSName &domain, const string &remote)
         L<<Logger::Error<<"Failed to load AXFR source '"<<localaddr[0]<<"' for incoming AXFR of '"<<domain<<"': "<<e.what()<<endl;
         return;
       }
-    } else {
+    } else { // should use global query-local-addr here! XXX
       laddr.sin4.sin_family = 0;
     }