From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 18 Jul 2009 04:06:25 +0000 (+1200)
Subject: Author: Isnard <isnardjaquet@gmail.com>
X-Git-Tag: SQUID_3_0_STABLE17~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bdabe2ceac3783aeddf59fc4b4b4b4fbee0e8748;p=thirdparty%2Fsquid.git

Author: Isnard <isnardjaquet@gmail.com>
Bug 2080: wbinfo_group.pl - false positive under certain conditions
---

diff --git a/helpers/external_acl/wbinfo_group/wbinfo_group.pl b/helpers/external_acl/wbinfo_group/wbinfo_group.pl
index d5fd00732b..06e970a759 100755
--- a/helpers/external_acl/wbinfo_group/wbinfo_group.pl
+++ b/helpers/external_acl/wbinfo_group/wbinfo_group.pl
@@ -50,6 +50,8 @@ sub check {
         $groupGID = `wbinfo -Y "$groupSID"`;
         chop $groupGID;
         &debug( "User:  -$user-\nGroup: -$group-\nSID:   -$groupSID-\nGID:   -$groupGID-");
+        return 'ERR' if($groupGID eq ""); # Verify if groupGID variable is empty.
+        return 'ERR' if(`wbinfo -r \Q$user\E` eq ""); # Verify if "wbinfo -r" command returns no value.
         return 'OK' if(`wbinfo -r \Q$user\E` =~ /^$groupGID$/m);
         return 'ERR';
 }