From: Iker Pedrosa <ipedrosa@redhat.com>
Date: Wed, 4 Feb 2026 09:31:47 +0000 (+0100)
Subject: tests/unit/test_chkhash.c: add MD5 and DES hash validation tests
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bdc661b82158e74d9a707a3f480002d3dfb761ee;p=thirdparty%2Fshadow.git

tests/unit/test_chkhash.c: add MD5 and DES hash validation tests

Add basic MD5 and DES algorithm validation tests.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
---

diff --git a/tests/unit/test_chkhash.c b/tests/unit/test_chkhash.c
index cdd4a37b4..3ae91b19f 100644
--- a/tests/unit/test_chkhash.c
+++ b/tests/unit/test_chkhash.c
@@ -110,6 +110,28 @@ test_is_valid_hash_ok_sha256(void **)
 }
 
 
+static void
+test_is_valid_hash_ok_md5(void **)
+{
+	// Basic MD5 hash: $1$ + salt + $ + 22 character hash
+	assert_true(is_valid_hash("$1$salt$abcdefghijklmnopqrstuv"));
+
+	// MD5 with maximum salt length (8 characters)
+	assert_true(is_valid_hash("$1$maxsalt8$abcdefghijklmnopqrstuv"));
+}
+
+
+static void
+test_is_valid_hash_ok_des(void **)
+{
+	// Basic DES hash: 13 characters
+	assert_true(is_valid_hash("abcDEF123./zZ"));
+
+	// DES with different character combinations
+	assert_true(is_valid_hash("ZZ./0123456xy"));
+}
+
+
 int
 main(void)
 {
@@ -118,6 +140,8 @@ main(void)
         cmocka_unit_test(test_is_valid_hash_ok_bcrypt),
         cmocka_unit_test(test_is_valid_hash_ok_sha512),
         cmocka_unit_test(test_is_valid_hash_ok_sha256),
+        cmocka_unit_test(test_is_valid_hash_ok_md5),
+        cmocka_unit_test(test_is_valid_hash_ok_des),
     };
 
     return cmocka_run_group_tests(tests, NULL, NULL);