From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 1 Jun 2025 22:55:27 +0000 (-0700)
Subject: factor: generalize BIG_POWER_OF_10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bdccb27ca67ad7b45d72ed5a2123b86a07f3984c;p=thirdparty%2Fcoreutils.git

factor: generalize BIG_POWER_OF_10

* src/factor.c (BIG_POWER_OF_10, LOG_BIG_POWER_OF_10):
Place fewer restrictions on BIG_POWER_OF_10.
This is only for currently-theoretical hosts;
it shouldn’t affect machine code on practical platforms.
---

diff --git a/src/factor.c b/src/factor.c
index 8fec474c0e..536e8638ac 100644
--- a/src/factor.c
+++ b/src/factor.c
@@ -242,19 +242,25 @@ make_uuint (wide_uint hi, wide_uint lo)
   return (uuint) {{lo, hi}};
 }
 
-/* BIG_POWER_OF_10 is a positive power of 10 that does not exceed WIDE_UINT_MAX.
+/* BIG_POWER_OF_10 is a positive power of 10 that fits in a word.
    The larger it is, the more efficient the code will likely be.
    LOG_BIG_POWER_OF_10 = log (BIG_POWER_OF_10).  */
-#if W_TYPE_SIZE < 64
-# error "platform does not support 64-bit integers"
+#if W_TYPE_SIZE < 4
+# error "Configuration error; platform word is impossibly narrow"
+#elif W_TYPE_SIZE < 30
+/* An unusually narrow word.  */
+static wide_uint const BIG_POWER_OF_10 = 10;
+enum { LOG_BIG_POWER_OF_10 = 1 };
+#elif W_TYPE_SIZE < 64
+/* Almost surely a 32-bit word.  */
+static wide_uint const BIG_POWER_OF_10 = 1000000000;
+enum { LOG_BIG_POWER_OF_10 = 9 };
 #elif W_TYPE_SIZE < 128
-/* A mainstream platforms, with at-least-64-bit uintmax_t.  */
+/* Almost surely a 64-bit word.  */
 static wide_uint const BIG_POWER_OF_10 = 10000000000000000000llu;
 enum { LOG_BIG_POWER_OF_10 = 19 };
 #else
-/* If built with -DUSE_INT128, a platform that supports __int128; otherwise,
-   a so-far-only-theoretical platform with at-least-128-bit uintmax_t.
-   This is for performance; the 64-bit mainstream code will still work.  */
+/* An unusually wide word.  */
 static wide_uint const BIG_POWER_OF_10 =
   (wide_uint) 10000000000000000000llu * 10000000000000000000llu;
 enum { LOG_BIG_POWER_OF_10 = 38 };