From: Michael Adkins <michael@prefect.io>
Date: Wed, 4 Jan 2023 09:23:32 +0000 (-0600)
Subject: Revert "Raise `TypeError` on invalid query params. (#2523)" (#2539)
X-Git-Tag: 0.23.3~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bddd774ce065f3442c1f46af1db5b85b1bfb7613;p=thirdparty%2Fhttpx.git

Revert "Raise `TypeError` on invalid query params. (#2523)" (#2539)

This reverts commit 4cbf13ece2e584b45b935df0a0c670e1863c4569.
---

diff --git a/httpx/_utils.py b/httpx/_utils.py
index 1e1570ee..1f64deed 100644
--- a/httpx/_utils.py
+++ b/httpx/_utils.py
@@ -67,11 +67,7 @@ def primitive_value_to_str(value: "PrimitiveData") -> str:
         return "false"
     elif value is None:
         return ""
-    elif isinstance(value, (str, float, int)):
-        return str(value)
-    raise TypeError(
-        f"Expected str, int, float, bool, or None. Got {type(value).__name__!r}."
-    )
+    return str(value)
 
 
 def is_known_encoding(encoding: str) -> bool:
diff --git a/tests/models/test_queryparams.py b/tests/models/test_queryparams.py
index cbb487bb..29b2ca63 100644
--- a/tests/models/test_queryparams.py
+++ b/tests/models/test_queryparams.py
@@ -87,13 +87,6 @@ def test_empty_query_params():
     assert str(q) == "a="
 
 
-def test_invalid_query_params():
-    with pytest.raises(
-        TypeError, match=r"Expected str, int, float, bool, or None. Got 'bytes'."
-    ):
-        httpx.QueryParams({"a": b"bytes"})
-
-
 def test_queryparam_update_is_hard_deprecated():
     q = httpx.QueryParams("a=123")
     with pytest.raises(RuntimeError):