From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 11 Oct 2023 09:09:09 +0000 (+0200)
Subject: limits-util: suppress noisy debug message when reading tasks in top-level cgroup
X-Git-Tag: v255-rc1~274^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bde7e12255a82f9b714fb3e44c291a79f7647cc9;p=thirdparty%2Fsystemd.git

limits-util: suppress noisy debug message when reading tasks in top-level cgroup

We have the "tasks.max" cgroup attribute only if we run in a cgroup
namespace, but not on the host. Hence let's handle ENODATA silently
simply to reduce the debug noise generated.
---

diff --git a/src/basic/limits-util.c b/src/basic/limits-util.c
index dc0a2a6c94b..9597c4c41cb 100644
--- a/src/basic/limits-util.c
+++ b/src/basic/limits-util.c
@@ -156,8 +156,11 @@ uint64_t system_tasks_max(void) {
         if (r < 0)
                 log_debug_errno(r, "Failed to determine cgroup root path, ignoring: %m");
         else {
+                /* We'll have the "pids.max" attribute on the our root cgroup only if we are in a
+                 * CLONE_NEWCGROUP namespace. On the top-level namespace this attribute is missing, hence
+                 * suppress any message about that */
                 r = cg_get_attribute_as_uint64("pids", root, "pids.max", &c);
-                if (r < 0)
+                if (r < 0 && r != -ENODATA)
                         log_debug_errno(r, "Failed to read pids.max attribute of root cgroup, ignoring: %m");
         }