From: Florian Krohm <florian@eich-krohm.de>
Date: Mon, 1 Sep 2014 06:37:07 +0000 (+0000)
Subject: Deprecate --db-attach   Fixes BZ #337871
X-Git-Tag: svn/VALGRIND_3_10_0~105
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=be54c05513c4998b1a56aae7bda1cdb519021e85;p=thirdparty%2Fvalgrind.git

Deprecate --db-attach   Fixes BZ #337871


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14401
---

diff --git a/NEWS b/NEWS
index 1448f5e3bd..b68e71bca6 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,13 @@ Release 3.10.0 (?? ?????? 201?)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 3.10.0 is not yet released.
 
+* ================== DEPRECATED FEATURES =================
+
+* --db-attach is now a deprecated feature which will be removed in the
+  next valgrind release (not counting bug-fix releases). The vgdb
+  capabilities are superior and should be used instead. Learn more here:
+  http://valgrind.org/docs/manual/manual-core-adv.html#manual-core-adv.gdbserver
+
 * ================== PLATFORM CHANGES =================
 
 * Support for Android on MIPS32.
@@ -231,6 +238,7 @@ where XXXXXX is the bug number as listed below.
 337094  ifunc wrapper is broken on ppc64
 337285  fcntl commands F_OFD_SETLK, F_OFD_SETLKW, and F_OFD_GETLK not supported
 337528  leak check heuristic for block prefixed by length as 64bit number
+337871  deprecate --db-attach
 338024  inlined functions are not shown if DW_AT_ranges is used
 338115  DRD: computed conflict set differs from actual after fork
 338160  implement display of thread local storage in gdbsrv
diff --git a/coregrind/m_main.c b/coregrind/m_main.c
index 7fdc3a72df..e880e44f33 100644
--- a/coregrind/m_main.c
+++ b/coregrind/m_main.c
@@ -132,6 +132,7 @@ static void usage_NORETURN ( Bool debug_help )
 "    --suppressions=<filename> suppress errors described in <filename>\n"
 "    --gen-suppressions=no|yes|all    print suppressions for errors? [no]\n"
 "    --db-attach=no|yes        start debugger when errors detected? [no]\n"
+"                              Note: deprecated feature\n"
 "    --db-command=<command>    command to start debugger [%s -nw %%f %%p]\n"
 "    --input-fd=<number>       file descriptor for input [0=stdin]\n"
 "    --dsymutil=no|yes         run dsymutil on Mac OS X when helpful? [no]\n"
@@ -815,6 +816,11 @@ void main_process_cmd_line_options ( /*OUT*/Bool* logging_to_fd,
 
    /* END command-line processing loop */
 
+   /* Notify about deprecated features */
+   if (VG_(clo_db_attach))
+      VG_(umsg)("\nWarning: --db-attach is a deprecated feature which will be removed\n"
+                "           in the next release. Use --vgdb-errors=1 instead\n\n");
+
    /* Determine the path prefix for vgdb */
    if (VG_(clo_vgdb_prefix) == NULL)
      VG_(clo_vgdb_prefix) = VG_(vgdb_prefix_default)();
diff --git a/docs/internals/3_9_BUGSTATUS.txt b/docs/internals/3_9_BUGSTATUS.txt
index e1fe48a315..786275598b 100644
--- a/docs/internals/3_9_BUGSTATUS.txt
+++ b/docs/internals/3_9_BUGSTATUS.txt
@@ -171,7 +171,6 @@ For bugs reported before this time, see 3_8_BUGSTATUS.txt
 === GDB server =========================================================
 
 328081  embedded gdbserver and non-stop mode (wishlist)
-337871  deprecate --db-attach=yes in favor of --vgdb-debug=1
 338633  gdbserver_tests/nlcontrolc.vgtest hangs on arm64
 
 === Output =============================================================