From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Thu, 14 Jul 2011 10:56:23 +0000 (+0100)
Subject: maint: fix warning 'possible use of "=" where "==" was intended'
X-Git-Tag: v8.13~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=be6120b5ccc02f4a9a0216f9d43eabdeb5f0dba0;p=thirdparty%2Fcoreutils.git

maint: fix warning 'possible use of "=" where "==" was intended'

* src/mktemp.c: maint: avoid warning by using the comma operator
rather than an always-true conditional (as suggested by Eric Blake).
Reported by Joachim Schmitz in http://debbugs.gnu.org/9064.
---

diff --git a/src/mktemp.c b/src/mktemp.c
index 2fe22b76bc..e592176a7c 100644
--- a/src/mktemp.c
+++ b/src/mktemp.c
@@ -344,7 +344,7 @@ main (int argc, char **argv)
       puts (dest_name);
       /* If we created a file, but then failed to output the file
          name, we should clean up the mess before failing.  */
-      if (!dry_run && (stdout_closed = true) && close_stream (stdout) != 0)
+      if (!dry_run && ((stdout_closed = true), close_stream (stdout) != 0))
         {
           int saved_errno = errno;
           remove (dest_name);