From: Chris Larson <chris_larson@mentor.com>
Date: Mon, 4 Apr 2011 16:41:41 +0000 (-0700)
Subject: event: register event handler functions, not code objects
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=be647dac9d458ee4b289ff5f66ed95b311d398d8;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

event: register event handler functions, not code objects

Signed-off-by: Chris Larson <chris_larson@mentor.com>
---

diff --git a/lib/bb/event.py b/lib/bb/event.py
index b289d368942..289217aaad7 100644
--- a/lib/bb/event.py
+++ b/lib/bb/event.py
@@ -63,18 +63,13 @@ def fire_class_handlers(event, d):
     if isinstance(event, logging.LogRecord):
         return
 
-    for handler in _handlers:
-        h = _handlers[handler]
+    for handler in _handlers.itervalues():
         event.data = d
-        if type(h).__name__ == "code":
-            locals = {"e": event}
-            bb.utils.simple_exec(h, locals)
-            ret = bb.utils.better_eval("tmpHandler(e)", locals)
-            if ret is not None:
-                warnings.warn("Using Handled/NotHandled in event handlers is deprecated",
-                              DeprecationWarning, stacklevel = 2)
-        else:
-            h(event)
+        ret = handler(event)
+        if ret is not None:
+            warnings.warn("Using Handled/NotHandled in event handlers is deprecated",
+                          DeprecationWarning, stacklevel = 2)
+
         del event.data
 
 ui_queue = []
@@ -149,7 +144,10 @@ def register(name, handler):
         if isinstance(handler, basestring):
             tmp = "def tmpHandler(e):\n%s" % handler
             comp = bb.utils.better_compile(tmp, "tmpHandler(e)", "bb.event._registerCode")
-            _handlers[name] = comp
+            env = {}
+            bb.utils.simple_exec(comp, env)
+            func = bb.utils.better_eval("tmpHandler", env)
+            _handlers[name] = func
         else:
             _handlers[name] = handler