From: Andrew Burgess <aburgess@redhat.com>
Date: Wed, 10 Jun 2026 18:43:24 +0000 (+0100)
Subject: gdb/testsuite: remove debug output messages from testsuite
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=be655796fa92c0059224f51e4599c854ffd7440f;p=thirdparty%2Fbinutils-gdb.git

gdb/testsuite: remove debug output messages from testsuite

Over time I've managed to leave various debug logging messages in the
testsuite, all of which include the 'APB' tag that I use to make
searching for these easier.  None of these were required, they could
all be removed.

I have left the logging output in gdb.base/stap-probe.exp (but with
the 'APB' removed) as it looked slightly useful, and it's harmless to
keep it.  But all of the other logging lines I just removed.

There should be no change in what is tested after this commit.
---

diff --git a/gdb/testsuite/gdb.base/attach-deleted-exec.exp b/gdb/testsuite/gdb.base/attach-deleted-exec.exp
index 61ee8647c9c..5d3f43eff00 100644
--- a/gdb/testsuite/gdb.base/attach-deleted-exec.exp
+++ b/gdb/testsuite/gdb.base/attach-deleted-exec.exp
@@ -97,8 +97,6 @@ if { [target_info gdb_protocol] == "extended-remote" } {
     set filename_re "\[^\r\n\]+/${testfile} \\(deleted\\)"
 }
 
-verbose -log "APB: warning: No executable has been specified, and target executable $filename_re could not be found\\.  Try using the \"file\" command\\."
-
 gdb_test "attach $testpid" \
     [multi_line \
 	 "Attaching to process $decimal" \
diff --git a/gdb/testsuite/gdb.base/stap-probe.exp b/gdb/testsuite/gdb.base/stap-probe.exp
index b157e2c13a7..00f91a5723a 100644
--- a/gdb/testsuite/gdb.base/stap-probe.exp
+++ b/gdb/testsuite/gdb.base/stap-probe.exp
@@ -90,16 +90,16 @@ proc check_for_usable_xmm0_probe { binfile } {
     # First, look for the xmmreg probe, and if we find it, grab the
     # argument string.
     if {![regexp {\n\s+Provider: test\n\s+Name: xmmreg\n[^\n]+\n\s+Arguments: ([^\n]+)\n} $output ignore arguments]} {
-	verbose -log "APB: Couldn't find probe at all"
+	verbose -log "Couldn't find probe at all"
 	return false
     }
 
-    verbose -log "APB: Matched on '$ignore'"
-    verbose -log "APB: arguments: '$arguments'"
+    verbose -log "Matched on '$ignore'"
+    verbose -log "  arguments: '$arguments'"
 
     # Check the argument string mentions xmm0.
     if {![regexp {@%?xmm0} $arguments]} {
-	verbose -log "APB: Prove doesn't use xmm0 register"
+	verbose -log "Probe doesn't use xmm0 register"
 	return false
     }
 
diff --git a/gdb/testsuite/gdb.cp/virtfunc.exp b/gdb/testsuite/gdb.cp/virtfunc.exp
index eecf4611e23..f6ff98d96f5 100644
--- a/gdb/testsuite/gdb.cp/virtfunc.exp
+++ b/gdb/testsuite/gdb.cp/virtfunc.exp
@@ -242,8 +242,6 @@ proc make_one_vtable_result {name args} {
 	set result [string range $result 0 end-[string length $nls]]
     }
 
-    verbose -log "APB: result: '$result'"
-
     return $result
 }
 
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-skipped-line-entries.exp b/gdb/testsuite/gdb.dwarf2/dw2-skipped-line-entries.exp
index c0b1265a8dc..1920ec3ee98 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-skipped-line-entries.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-skipped-line-entries.exp
@@ -173,8 +173,6 @@ proc check_end_markers { expected_symtab test_spec } {
 	upvar 1 $varname upvar_addr
 	set addr [string range $upvar_addr 2 end]
 
-	verbose -log "APB: index: $index, addr: $addr"
-
 	set symtab ""
 	set saw_line false
 	gdb_test_multiple "maint info line-table" \
diff --git a/gdb/testsuite/gdb.fortran/lbound-ubound.exp b/gdb/testsuite/gdb.fortran/lbound-ubound.exp
index e0bcbbd62ea..6d3c4b98779 100644
--- a/gdb/testsuite/gdb.fortran/lbound-ubound.exp
+++ b/gdb/testsuite/gdb.fortran/lbound-ubound.exp
@@ -76,10 +76,6 @@ while { $test_count < 500 } {
 	    error "failed to extract expected results for ubound"
 	}
 
-	verbose -log "APB: Run a test here"
-	verbose -log "APB: Expected lbound '$expected_lbound'"
-	verbose -log "APB: Expected ubound '$expected_ubound'"
-
 	# We want to take a look at the line in the previous frame that
 	# called the current function.  I couldn't find a better way of
 	# doing this than 'up', which will print the line, then 'down'
diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index ca2278606d6..839c5174265 100644
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -143,8 +143,6 @@ proc build_executable_and_dwo_files { testname executable options args } {
 	    return -1
 	}
 
-	verbose -log "APB: SPEC: $spec"
-
 	set s [lindex $spec 0]
 	set local_options [lindex $spec 1]
 
@@ -182,8 +180,6 @@ proc build_executable_and_dwo_files { testname executable options args } {
 	}
     }
 
-    verbose -log "APB: OBJECTS = $objects"
-
     set ret [$func $objects "${binfile}" executable $options]
     if  { $ret != "" } {
 	untested $testname