From: James Jones <jejones3141@gmail.com>
Date: Fri, 19 Jan 2024 18:57:03 +0000 (-0600)
Subject: Remove dead code (CID #1504016)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=be78380dc5a658d296999295e6b3d91e6c2c1a35;p=thirdparty%2Ffreeradius-server.git

Remove dead code (CID #1504016)

In fr_value_box_from_substr(), the first switch on dst_type handles
the FR_TYPE_COMBO_IP_{ADDR, PREFIX} cases, so that dst_type can't
have those values when the second switch on dst_type is executed.
---

diff --git a/src/lib/util/value.c b/src/lib/util/value.c
index 6689863682f..0ad55a9c5c9 100644
--- a/src/lib/util/value.c
+++ b/src/lib/util/value.c
@@ -5227,23 +5227,6 @@ parse:
 		}
 		break;
 
-	/*
-	 *	Crazy polymorphic (IPv4/IPv6) attribute src->dst_type for WiMAX.
-	 *
-	 *	We try and make is saner by replacing the original
-	 *	da, with either an IPv4 or IPv6 da src->dst_type.
-	 *
-	 *	These are not dynamic da, and will have the same vendor
-	 *	and attribute as the original.
-	 */
-	case FR_TYPE_COMBO_IP_ADDR:
-		if (fr_inet_pton(&dst->vb_ip, buffer, strlen(buffer), AF_UNSPEC, fr_hostname_lookups, true) < 0) return -1;
-		break;
-
-	case FR_TYPE_COMBO_IP_PREFIX:
-		if (fr_inet_pton(&dst->vb_ip, buffer, strlen(buffer), AF_UNSPEC, fr_hostname_lookups, true) < 0) return -1;
-		break;
-
 	default:
 		fr_strerror_printf("Cannot parse input as data type %s", fr_type_to_str(dst_type));
 		return -1;