From: Lukáš Ondráček <lukas.ondracek@nic.cz>
Date: Tue, 30 Jul 2024 14:50:41 +0000 (+0200)
Subject: defer: fix/hide tidy/trivial_checks warnings
X-Git-Tag: v6.0.9~1^2~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=be87bc83b5f07ee64582ca8524db17d82f9f052d;p=thirdparty%2Fknot-resolver.git

defer: fix/hide tidy/trivial_checks warnings
---

diff --git a/.clang-tidy b/.clang-tidy
index 4d77c1a7d..32816a96a 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -16,6 +16,7 @@ Checks: |-
   -bugprone-sizeof-expression,
   -bugprone-suspicious-string-compare,
   -cert-dcl03-c,
+  -cert-dcl16-c,
   -clang-analyzer-deadcode.DeadStores,
   -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
   -clang-analyzer-unix.Malloc,
@@ -37,6 +38,7 @@ Checks: |-
   -readability-magic-numbers,
   -readability-non-const-parameter,
   -readability-redundant-declaration,
+  -readability-uppercase-literal-suffix,
   -clang-analyzer-core.UndefinedBinaryOperatorResult
 
 # TODO: remove `-clang-analyzer-core.UndefinedBinaryOperatorResult` when we
diff --git a/ci/no_assert_check.sh b/ci/no_assert_check.sh
index 610011a10..4bb7ccfcd 100755
--- a/ci/no_assert_check.sh
+++ b/ci/no_assert_check.sh
@@ -1,3 +1,3 @@
 #!/bin/sh
-grep '\<assert\>' -- $(git ls-files | grep '\.[hc]$' | grep -vE '^(contrib|bench|tests|daemon/rrl)/')
+grep '\<assert\>' -- $(git ls-files | grep '\.[hc]$' | grep -vE '^(contrib|bench|tests|daemon/ratelimiting.test|lib/kru)/')
 test $? -eq 1
diff --git a/contrib/meson.build b/contrib/meson.build
index 5d97e8891..e7dccae97 100644
--- a/contrib/meson.build
+++ b/contrib/meson.build
@@ -10,7 +10,8 @@ contrib_src = files([
   'murmurhash3/murmurhash3.c',
   'base32hex.c',
   'base64.c',
-  'base64url.c'
+  'base64url.c',
+  'openbsd/siphash.c',
 ])
 
 contrib_inc = include_directories('.', '..')
diff --git a/daemon/defer.c b/daemon/defer.c
index 89d792652..1908f478f 100644
--- a/daemon/defer.c
+++ b/daemon/defer.c
@@ -21,7 +21,8 @@
 
 #define KRU_CAPACITY  (1<<10)
 #define MAX_DECAY     (KRU_LIMIT * 0.0006929)  // -> halving counters in 1s
-#define TIME_MULT     1/1   // max fraction of rate limit filled by one cpu (multiplies large int)
+#define TIME_MULT     1/1   // NOLINT for now, TODO improve readability
+	// max fraction of rate limit filled by one cpu (multiplies large int)
 	// TODO divide by #cpus?
 
 #define REQ_TIMEOUT        5000000 // ns (THREAD_CPUTIME), older deferred queries are dropped
diff --git a/lib/meson.build b/lib/meson.build
index 9f611e3a9..e369a4526 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -40,7 +40,6 @@ libkres_src = files([
   'selection_iter.c',
   'utils.c',
   'zonecut.c',
-  '../contrib/openbsd/siphash.c', # needed for kru
 ])
 c_src_lint += libkres_src