From: Volker Lendecke <vl@samba.org>
Date: Tue, 24 Feb 2026 09:15:27 +0000 (+0100)
Subject: winbindd: Call dom_sid_str_buf() only once
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=beadf68818ec2ebe031aa163b437fef782d79317;p=thirdparty%2Fsamba.git

winbindd: Call dom_sid_str_buf() only once

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
---

diff --git a/source3/winbindd/winbindd_getuserdomgroups.c b/source3/winbindd/winbindd_getuserdomgroups.c
index 75eb4376c44..3187be6d586 100644
--- a/source3/winbindd/winbindd_getuserdomgroups.c
+++ b/source3/winbindd/winbindd_getuserdomgroups.c
@@ -107,14 +107,12 @@ NTSTATUS winbindd_getuserdomgroups_recv(struct tevent_req *req,
 		 state->num_sids);
 	for (i=0; i<state->num_sids; i++) {
 		struct dom_sid_buf tmp;
-		sidlist = talloc_asprintf_append_buffer(
-			sidlist, "%s\n",
-			dom_sid_str_buf(&state->sids[i], &tmp));
+		const char *str = dom_sid_str_buf(&state->sids[i], &tmp);
+		sidlist = talloc_asprintf_append_buffer(sidlist, "%s\n", str);
 		if (sidlist == NULL) {
 			return NT_STATUS_NO_MEMORY;
 		}
-		D_NOTICE("%"PRIu32": %s\n",
-			 i, dom_sid_str_buf(&state->sids[i], &tmp));
+		D_NOTICE("%" PRIu32 ": %s\n", i, str);
 	}
 	response->extra_data.data = sidlist;
 	response->length += talloc_get_size(sidlist);