From: Baptiste Daroussin <bapt@FreeBSD.org>
Date: Wed, 5 Jul 2023 13:23:30 +0000 (+0200)
Subject: sub: remove useless interlediary variable
X-Git-Tag: RELEASE_1_4_0rc1~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bed062f95d3c1f96dd0c70f05e79ca1afe3bdf29;p=thirdparty%2Fmlmmj.git

sub: remove useless interlediary variable
---

diff --git a/src/subscriberfuncs.c b/src/subscriberfuncs.c
index 566a985e..69a6ffc8 100644
--- a/src/subscriberfuncs.c
+++ b/src/subscriberfuncs.c
@@ -404,7 +404,7 @@ void
 mod_get_addr_and_type(struct ml *ml, const char *modstr, char **addrptr, enum subtype *subtypeptr)
 {
 	int fd;
-	char *readaddr, *readtype, *modfilename;
+	char *readtype, *modfilename;
 	char *buf, *walk;
 
 	if (strncmp(modstr, "subscribe", 9) == 0)
@@ -422,9 +422,8 @@ mod_get_addr_and_type(struct ml *ml, const char *modstr, char **addrptr, enum su
 		log_error(LOG_ARGS, "Could not open %s/%s", ml->dir, modfilename);
 		exit(EXIT_FAILURE);
 	}
-	readaddr = xstrdup(strsep(&walk, "\n"));
+	*addrptr = xstrdup(strsep(&walk, "\n"));
 	readtype = strsep(&walk, "\n");
-	*addrptr = readaddr;
 
 	for (size_t i = 0; i < NELEM(subtypes); i++) {
 		if (subtypes[i] == NULL)