From: Eric Wong <e@80x24.org>
Date: Mon, 27 Nov 2023 07:26:28 +0000 (+0000)
Subject: t/nntpd-tls: avoid test failure on OpenBSD 7.3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bedd1b759b3bcaa471bffc97391d8c04cdcbd550;p=thirdparty%2Fpublic-inbox.git

t/nntpd-tls: avoid test failure on OpenBSD 7.3

The LibreSSL 3.7.2 on my OpenBSD 7.3 VM seems return 7 bytes of
junk data before EOF/ECONNRESET when a client attempts to write
plain-text to a TLS socket.

Tested-by: Štěpán Němec <stepnem@smrk.net>
---

diff --git a/t/nntpd-tls.t b/t/nntpd-tls.t
index a11a0dd9b..a16cc015e 100644
--- a/t/nntpd-tls.t
+++ b/t/nntpd-tls.t
@@ -187,8 +187,12 @@ for my $args (
 
 	my $s = tcp_connect($nntps);
 	syswrite($s, '->accept_SSL_ will fail on this!');
-	ok(!sysread($s, my $rbuf, 128), 'EOF or ECONNRESET on ->accept_SSL fail');
-
+	my @r;
+	do { # some platforms or OpenSSL versions need an extra read
+		push @r, sysread($s, my $rbuf, 128);
+	} while ($r[-1] && @r < 2);
+	ok(!$r[-1], 'EOF or ECONNRESET on ->accept_SSL fail') or
+		diag explain(\@r);
 	$c = undef;
 	$td->kill;
 	$td->join;