From: nathan-williams <nathan.le.williams@gmail.com>
Date: Thu, 18 Jul 2024 17:24:45 +0000 (-0400)
Subject: Enforce language name structure for both name and preferred name
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bee8c9f22e60fdf0bd49dc586af2ff365a413295;p=thirdparty%2Fgoogle%2Ffonts.git

Enforce language name structure for both name and preferred name
---

diff --git a/tests/test_data_languages.py b/tests/test_data_languages.py
index 4c244db4e7..3ce6a44f12 100644
--- a/tests/test_data_languages.py
+++ b/tests/test_data_languages.py
@@ -289,11 +289,13 @@ def test_language_uniqueness():
 
 def test_language_name_structure():
     for lang in LANGUAGES.values():
-        language_name = lang.preferred_name if lang.preferred_name else lang.name
         script_name = SCRIPTS[lang.script].name
-        if not re.match(LANGUAGE_NAME_REGEX, language_name):
-            pytest.fail(
-                f"Language name does not have expected structure (\"LANGUAGE, MODIFIER (SCRIPT)\"): {language_name}")
-        if language_name.endswith(")") and not language_name.endsWith(f"({script_name})"):
-            pytest.fail(
-                f"Language name parenthetical should contain script name ({script_name}): {language_name}")
+        for type, name in [["name", lang.name], ["preferred_name", lang.preferred_name]]:
+            if name is None:
+                continue
+            if not re.match(LANGUAGE_NAME_REGEX, name):
+                pytest.fail(
+                    f"Language {type} does not have expected structure (\"LANGUAGE, MODIFIER (SCRIPT)\"): {name}")
+            if name.endswith(")") and not name.endsWith(f"({script_name})"):
+                pytest.fail(
+                    f"Language {type} parenthetical should contain script name ({script_name}): {name}")