From: Vasil Velichkov <vvvelichkov@gmail.com>
Date: Fri, 1 Sep 2023 22:29:07 +0000 (+0300)
Subject: groupadd: Improve error message when opening group file fails.
X-Git-Tag: 4.15.0-rc1~177
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bef4da47be72a7fd63f87f327daea9669746bb65;p=thirdparty%2Fshadow.git

groupadd: Improve error message when opening group file fails.

Both gr_open and sgr_open are using commonio_open function and when
there is a failure this function sets errno accordingly.
---

diff --git a/src/groupadd.c b/src/groupadd.c
index 462a4ccd2..d24218455 100644
--- a/src/groupadd.c
+++ b/src/groupadd.c
@@ -344,8 +344,8 @@ static void open_files (void)
 
 	/* And now open the databases */
 	if (gr_open (O_CREAT | O_RDWR) == 0) {
-		fprintf (stderr, _("%s: cannot open %s\n"), Prog, gr_dbname ());
-		SYSLOG ((LOG_WARN, "cannot open %s", gr_dbname ()));
+		fprintf (stderr, _("%s: cannot open %s: %s\n"), Prog, gr_dbname (), strerror(errno));
+		SYSLOG ((LOG_WARN, "cannot open %s: %s", gr_dbname (), strerror(errno)));
 		exit (E_GRP_UPDATE);
 	}
 
@@ -353,9 +353,9 @@ static void open_files (void)
 	if (is_shadow_grp) {
 		if (sgr_open (O_CREAT | O_RDWR) == 0) {
 			fprintf (stderr,
-			         _("%s: cannot open %s\n"),
-			         Prog, sgr_dbname ());
-			SYSLOG ((LOG_WARN, "cannot open %s", sgr_dbname ()));
+			         _("%s: cannot open %s: %s\n"),
+			         Prog, sgr_dbname (), strerror(errno));
+			SYSLOG ((LOG_WARN, "cannot open %s: %s", sgr_dbname (), strerror(errno)));
 			exit (E_GRP_UPDATE);
 		}
 	}