From: Andreas Schneider Date: Mon, 22 Mar 2021 17:11:33 +0000 (+0100) Subject: auth:creds: Free the uname pointer in cli_credentials_parse_string() X-Git-Tag: tevent-0.11.0~1402 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bf1c294adb7ef623d0da1dd9b43d3b3fab58fa26;p=thirdparty%2Fsamba.git auth:creds: Free the uname pointer in cli_credentials_parse_string() The data is duplicated and we don't need it anymore. Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Wed Mar 24 03:13:05 UTC 2021 on sn-devel-184 --- diff --git a/auth/credentials/credentials.c b/auth/credentials/credentials.c index 6596a227bee..d851951c9ed 100644 --- a/auth/credentials/credentials.c +++ b/auth/credentials/credentials.c @@ -824,6 +824,7 @@ bool cli_credentials_set_workstation_callback(struct cli_credentials *cred, _PUBLIC_ void cli_credentials_parse_string(struct cli_credentials *credentials, const char *data, enum credentials_obtained obtained) { char *uname, *p; + char *uname_free = NULL; if (strcmp("%",data) == 0) { cli_credentials_set_anonymous(credentials); @@ -831,6 +832,8 @@ _PUBLIC_ void cli_credentials_parse_string(struct cli_credentials *credentials, } uname = talloc_strdup(credentials, data); + uname_free = uname; + if ((p = strchr_m(uname,'%'))) { *p = 0; cli_credentials_set_password(credentials, p+1, obtained); @@ -848,6 +851,7 @@ _PUBLIC_ void cli_credentials_parse_string(struct cli_credentials *credentials, cli_credentials_set_principal(credentials, uname, obtained); *p = 0; cli_credentials_set_realm(credentials, p+1, obtained); + TALLOC_FREE(uname_free); return; } else if ((p = strchr_m(uname,'\\')) || (p = strchr_m(uname, '/')) @@ -889,6 +893,8 @@ _PUBLIC_ void cli_credentials_parse_string(struct cli_credentials *credentials, credentials->principal = NULL; } cli_credentials_set_username(credentials, uname, obtained); + + TALLOC_FREE(uname_free); } /**