From: A. Jesse Jiryu Davis <jesse@10gen.com>
Date: Fri, 12 Apr 2013 19:39:43 +0000 (-0400)
Subject: gen_test requires `timeout` passed as a keyword argument
X-Git-Tag: v3.1.0~106^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bf21f83cd0f7fde3f155c2ae8c1d3ee8b90edaa9;p=thirdparty%2Ftornado.git

gen_test requires `timeout` passed as a keyword argument
---

diff --git a/tornado/testing.py b/tornado/testing.py
index 1330ea205..67bab88e5 100644
--- a/tornado/testing.py
+++ b/tornado/testing.py
@@ -32,7 +32,6 @@ from tornado.log import gen_log
 from tornado.stack_context import ExceptionStackContext
 from tornado.util import raise_exc_info, basestring_type
 import functools
-import inspect
 import logging
 import os
 import re
@@ -355,7 +354,7 @@ class AsyncHTTPSTestCase(AsyncHTTPTestCase):
         return 'https'
 
 
-def gen_test(timeout=None):
+def gen_test(func=None, timeout=None):
     """Testing equivalent of ``@gen.coroutine``, to be applied to test methods.
 
     ``@gen.coroutine`` cannot be used on tests because the `.IOLoop` is not
@@ -371,7 +370,7 @@ def gen_test(timeout=None):
 
     By default, ``@gen_test`` times out after 5 seconds. The timeout may be
     overridden globally with the TIMEOUT environment variable, or for each
-    test with the ``timeout`` parameter:
+    test with the ``timeout`` keyword argument:
 
         class MyTest(AsyncHTTPTestCase):
             @gen_test(timeout=10)
@@ -395,22 +394,16 @@ def gen_test(timeout=None):
                 functools.partial(f, self), timeout=timeout)
         return wrapper
 
-    if inspect.isfunction(timeout):
+    if func is not None:
         # Used like:
         #     @gen_test
         #     def f(self):
         #         pass
-        # The 'timeout' parameter is actually the test function.
-        f = timeout
         timeout = env_timeout or 5
-        return wrap(f)
+        return wrap(func)
     else:
-        # Used like @gen_test(timeout=10) or @gen_test(10).
-        if env_timeout is not None:
-            timeout = max(float(timeout), env_timeout)
-        else:
-            timeout = float(timeout)
-
+        # Used like @gen_test(timeout=10)
+        timeout = float(timeout)
         return wrap