From: William King <william.king@quentustech.com>
Date: Fri, 9 Oct 2015 18:08:19 +0000 (-0700)
Subject: FS-8316 more clean code this way
X-Git-Tag: v1.6.3~1^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bf38cd2388e42212ab063d48a11e60f4fa171779;p=thirdparty%2Ffreeswitch.git

FS-8316 more clean code this way
---

diff --git a/src/mod/endpoints/mod_skinny/skinny_server.c b/src/mod/endpoints/mod_skinny/skinny_server.c
index 497bf68b84..85673df525 100644
--- a/src/mod/endpoints/mod_skinny/skinny_server.c
+++ b/src/mod/endpoints/mod_skinny/skinny_server.c
@@ -149,13 +149,13 @@ switch_status_t skinny_create_incoming_session(listener_t *listener, uint32_t *l
 		goto error;
 	}
 	/* First create the caller profile in the patterns Dialplan */
-	if ((tech_pvt->caller_profile = switch_caller_profile_new(switch_core_session_get_pool(nsession),
-					NULL, listener->profile->patterns_dialplan, 
-					button->displayname, button->shortname, 
+	if (!(tech_pvt->caller_profile = switch_caller_profile_new(switch_core_session_get_pool(nsession),
+					NULL, listener->profile->patterns_dialplan,
+					button->displayname, button->shortname,
 					listener->remote_ip, NULL, NULL, NULL,
 					"skinny" /* modname */,
-					listener->profile->patterns_context, 
-					"")) == NULL) {
+					listener->profile->patterns_context,
+					""))) {
 		skinny_log_ls_msg(listener, nsession, SWITCH_LOG_CRIT, "Error Creating Session caller profile\n");
 		goto error;
 	}