From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 12 Sep 2024 10:01:35 +0000 (+0200)
Subject: dnsdist: Fix a clang-tidy warning in bpf-filter.cc
X-Git-Tag: rec-5.2.0-alpha1~86^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bf682499deab4b919eb3a27b3de5e3baaec05f51;p=thirdparty%2Fpdns.git

dnsdist: Fix a clang-tidy warning in bpf-filter.cc
---

diff --git a/pdns/dnsdistdist/bpf-filter.cc b/pdns/dnsdistdist/bpf-filter.cc
index fc398b867e..db8c358b1c 100644
--- a/pdns/dnsdistdist/bpf-filter.cc
+++ b/pdns/dnsdistdist/bpf-filter.cc
@@ -35,6 +35,7 @@
 
 static __u64 ptr_to_u64(const void* ptr)
 {
+  // NOLINTNEXTLINE(cppcoreguidelines-pro-type-cstyle-cast)
   return (__u64)(unsigned long)ptr;
 }
 
@@ -195,8 +196,8 @@ struct QNameValue
   uint16_t qtype{0};
 };
 
-BPFFilter::Map::Map(const BPFFilter::MapConfiguration& config, BPFFilter::MapFormat format) :
-  d_config(config)
+BPFFilter::Map::Map(BPFFilter::MapConfiguration config, BPFFilter::MapFormat format) :
+  d_config(std::move(config))
 {
   if (d_config.d_type == BPFFilter::MapType::Filters) {
     /* special case, this is a map of eBPF programs */
diff --git a/pdns/dnsdistdist/bpf-filter.hh b/pdns/dnsdistdist/bpf-filter.hh
index b4f4ea1da4..46b7eed9dc 100644
--- a/pdns/dnsdistdist/bpf-filter.hh
+++ b/pdns/dnsdistdist/bpf-filter.hh
@@ -111,7 +111,7 @@ private:
     Map()
     {
     }
-    Map(const MapConfiguration&, MapFormat);
+    Map(MapConfiguration, MapFormat);
     MapConfiguration d_config;
     uint32_t d_count{0};
     FDWrapper d_fd;