From: Hans de Goede Date: Mon, 30 Sep 2019 09:12:45 +0000 (+0200) Subject: space-flares: Fix compiler warning X-Git-Tag: 0.9.5~36^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bf6ef0a4815d6331e7d903eded14574a32f66ff3;p=thirdparty%2Fplymouth.git space-flares: Fix compiler warning Recent gcc versions give the following compiler warning with space-flares: ./plugin.c: In function ‘star_bg_update’: ./plugin.c:762:21: warning: taking the absolute value of unsigned type ‘uint32_t’ {aka ‘unsigned int’} has no effect [-Wabsolute-value] 762 | if (abs (((image_data[x + y * width] >> 16) & 0xff) - ((pixel_colour >> 16) & 0xff)) > 8) { | ^~~ This commit fixes this, assuming that gcc actually optimises the abs() away, this will also make the code behave as intended again. Signed-off-by: Hans de Goede --- diff --git a/src/plugins/splash/space-flares/plugin.c b/src/plugins/splash/space-flares/plugin.c index 5af99c11..1b28268f 100644 --- a/src/plugins/splash/space-flares/plugin.c +++ b/src/plugins/splash/space-flares/plugin.c @@ -759,7 +759,7 @@ star_bg_update (view_t *view, sprite_t *sprite, double time) x = star_bg->star_x[i]; y = star_bg->star_y[i]; uint32_t pixel_colour = star_bg_gradient_colour (x, y, width, height, true, time); - if (abs (((image_data[x + y * width] >> 16) & 0xff) - ((pixel_colour >> 16) & 0xff)) > 8) { + if (abs ((int)((image_data[x + y * width] >> 16) & 0xff) - (int)((pixel_colour >> 16) & 0xff)) > 8) { image_data[x + y * width] = pixel_colour; star_bg->star_refresh[i] = 1; }