From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Fri, 1 Sep 2023 10:14:00 +0000 (+0200)
Subject: Add config parsing test
X-Git-Tag: v16~23^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bf890514a21ed57dafdfc9a96119891eef80b359;p=thirdparty%2Fmkosi.git

Add config parsing test
---

diff --git a/tests/test_config.py b/tests/test_config.py
index d68716ea3..e5c040516 100644
--- a/tests/test_config.py
+++ b/tests/test_config.py
@@ -2,7 +2,10 @@
 
 from pathlib import Path
 
-from mkosi.config import Compression, parse_ini
+from mkosi.architecture import Architecture
+from mkosi.config import Compression, OutputFormat, parse_config, parse_ini
+from mkosi.distributions import Distribution
+from mkosi.util import chdir
 
 
 def test_compression_enum_creation() -> None:
@@ -63,3 +66,97 @@ def test_parse_ini(tmp_path: Path) -> None:
     assert next(g) == ("MySection", "ALLCAPS", "txt")
     assert next(g) == ("AnotherSection", "EmptyValue", "")
     assert next(g) == ("AnotherSection", "Multiline", "abc\ndef\nqed\nord")
+
+
+def test_parse_config(tmp_path: Path) -> None:
+    d = tmp_path
+
+    (d / "mkosi.conf").write_text(
+        """\
+        [Distribution]
+
+        @Distribution = ubuntu
+        Architecture  = arm64
+
+        [Content]
+        Packages=abc
+
+        [Output]
+        @Format = cpio
+        ImageId = base
+        """
+    )
+
+    with chdir(tmp_path):
+        _, [config] = parse_config()
+
+    assert config.distribution == Distribution.ubuntu
+    assert config.architecture == Architecture.arm64
+    assert config.packages == ["abc"]
+    assert config.output_format == OutputFormat.cpio
+    assert config.image_id == "base"
+
+    with chdir(tmp_path):
+        _, [config] = parse_config(["--distribution", "fedora", "--architecture", "x86-64"])
+
+    # mkosi.conf sets a default distribution, so the CLI should take priority.
+    assert config.distribution == Distribution.fedora
+    # mkosi.conf sets overrides the architecture, so whatever is specified on the CLI should be ignored.
+    assert config.architecture == Architecture.arm64
+
+    d = d / "mkosi.conf.d"
+    d.mkdir()
+
+    (d / "d1.conf").write_text(
+        """\
+        [Distribution]
+        Distribution = debian
+        @Architecture = x86-64
+
+        [Content]
+        Packages = qed
+                   def
+
+        [Output]
+        ImageId = 00-dropin
+        ImageVersion = 0
+        """
+    )
+
+    with chdir(tmp_path):
+        _, [config] = parse_config()
+
+    # Setting a value explicitly in a dropin should override the default from mkosi.conf.
+    assert config.distribution == Distribution.debian
+    # Setting a default in a dropin should be ignored since mkosi.conf sets the architecture explicitly.
+    assert config.architecture == Architecture.arm64
+    # Lists should be merged by appending the new values to the existing values.
+    assert config.packages == ["abc", "qed", "def"]
+    assert config.output_format == OutputFormat.cpio
+    assert config.image_id == "00-dropin"
+    assert config.image_version == "0"
+
+    (tmp_path / "mkosi.version").write_text("1.2.3")
+
+    (d / "d2.conf").write_text(
+        """\
+        [Content]
+        Packages=
+        """
+    )
+
+    with chdir(tmp_path):
+        _, [config] = parse_config()
+
+    # Test that empty string resets the list.
+    assert config.packages == []
+    # mkosi.version should only be used if no version is set explicitly.
+    assert config.image_version == "0"
+
+    (d / "d1.conf").unlink()
+
+    with chdir(tmp_path):
+        _, [config] = parse_config()
+
+    # ImageVersion= is not set explicitly anymore, so now the version from mkosi.version should be used.
+    assert config.image_version == "1.2.3"