From: Rafael J. Wysocki Date: Mon, 22 Dec 2025 20:31:45 +0000 (+0100) Subject: scsi: ufs: core: Discard pm_runtime_put() return values X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bf91b35a46ceef08a1e64c54b0e611fcae531e7a;p=thirdparty%2Flinux.git scsi: ufs: core: Discard pm_runtime_put() return values The ufshcd driver defines ufshcd_rpm_put() to return an int, but that return value is never used. It also passes the return value of pm_runtime_put() to the caller which is not very useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. Modify ufshcd_rpm_put() to discard the pm_runtime_put() return value and change its return type to void. No intentional functional impact. This will facilitate a planned change of the pm_runtime_put() return type to void in the future. Signed-off-by: Rafael J. Wysocki Reviewed-by: Bart Van Assche Reviewed-by: Martin K. Petersen Link: https://patch.msgid.link/2781685.BddDVKsqQX@rafael.j.wysocki --- diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h index 4259f499382fa..27b18b0cc0584 100644 --- a/drivers/ufs/core/ufshcd-priv.h +++ b/drivers/ufs/core/ufshcd-priv.h @@ -348,9 +348,9 @@ static inline int ufshcd_rpm_resume(struct ufs_hba *hba) return pm_runtime_resume(&hba->ufs_device_wlun->sdev_gendev); } -static inline int ufshcd_rpm_put(struct ufs_hba *hba) +static inline void ufshcd_rpm_put(struct ufs_hba *hba) { - return pm_runtime_put(&hba->ufs_device_wlun->sdev_gendev); + pm_runtime_put(&hba->ufs_device_wlun->sdev_gendev); } /**