From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 24 Dec 2024 13:39:59 +0000 (+0000)
Subject: log buffer: Since length is signed, we cannot assign -1
X-Git-Tag: 0.9.30~689
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bfbb386a695658bda024cf5450577e1471f29ea0;p=pakfire.git

log buffer: Since length is signed, we cannot assign -1

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/log_buffer.c b/src/libpakfire/log_buffer.c
index 1852e6f0d..1e1c63dda 100644
--- a/src/libpakfire/log_buffer.c
+++ b/src/libpakfire/log_buffer.c
@@ -161,7 +161,7 @@ int pakfire_log_buffer_dequeue(struct pakfire_log_buffer* buffer, int* priority,
 		*line = NULL;
 
 		if (length)
-			*length = -1;
+			*length = 0;
 
 		return 0;
 	}
diff --git a/tests/libpakfire/log_buffer.c b/tests/libpakfire/log_buffer.c
index 834cbb822..12228b309 100644
--- a/tests/libpakfire/log_buffer.c
+++ b/tests/libpakfire/log_buffer.c
@@ -65,7 +65,7 @@ static int test_simple(const struct test* t) {
 
 	ASSERT_EQUALS(priority, -1);
 	ASSERT_EQUALS(line, NULL);
-	ASSERT_EQUALS(length, -1);
+	ASSERT_EQUALS(length, 0);
 
 	// Everything passed
 	r = EXIT_SUCCESS;