From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Tue, 2 Jul 2024 23:23:36 +0000 (+1200)
Subject: cmdline:burn: explicitly burn --username
X-Git-Tag: samba-4.19.8~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bfdd8d17d00d3bde92a118eb7e3d7a77e1e03989;p=thirdparty%2Fsamba.git

cmdline:burn: explicitly burn --username

This is the long form of -U in samba-tool.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jo Sutton <josutton@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674
(cherry picked from commit 63a83fb7bb312731047f361f89766e0be492f83e)
---

diff --git a/lib/cmdline/cmdline.c b/lib/cmdline/cmdline.c
index 5fb9e306d99..81f37774dca 100644
--- a/lib/cmdline/cmdline.c
+++ b/lib/cmdline/cmdline.c
@@ -243,6 +243,10 @@ bool samba_cmdline_burn(int argc, char *argv[])
 			ulen = 6;
 			found = true;
 			is_user = true;
+		} else if (strneq_cmdline_exact(p, "--username", 10)) {
+			ulen = 10;
+			found = true;
+			is_user = true;
 		} else if (strncmp(p, "--", 2) == 0 && strstr(p, "pass")) {
 			/*
 			 * We have many secret options like --password,
diff --git a/selftest/knownfail.d/cmdline b/selftest/knownfail.d/cmdline
deleted file mode 100644
index c9e4a86609c..00000000000
--- a/selftest/knownfail.d/cmdline
+++ /dev/null
@@ -1 +0,0 @@
-^samba.unittests.cmdline.torture_cmdline_burn.none.$